[SPARK-32478][R][SQL] Error message to show the schema mismatch in gapply with Arrow vectorization #29283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
force-pushed
the
r-vectorized-error
branch
from
8ed454a to
ab5ecde
Compare
HyukjinKwon
commented
Jul 29, 2020
| val actualDataTypes = (0 until batch.numCols()).map(i => batch.column(i).dataType()) | ||
| assert(outputTypes == actualDataTypes, "Invalid schema from gapply(): " + | ||
| s"expected ${outputTypes.mkString(", ")}, got ${actualDataTypes.mkString(", ")}") | ||
| batch.rowIterator().asScala |
Member
Author
There was a problem hiding this comment.
This is same as dapply:
spark/sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala
Lines 247 to 251 in 17586f9
Member
Author
|
@viirya can you take a quick look when you're available? |
|
Test build #126766 has finished for PR 29283 at commit
|
|
Test build #126767 has finished for PR 29283 at commit
|
viirya
reviewed
Jul 30, 2020
viirya
approved these changes
Jul 30, 2020
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
It looks nice, the improved error message. Just one minor comment about the doc.
Member
|
LGTM |
Member
Author
|
Merged to master and branch-3.0. Thanks @viirya. |
HyukjinKwon
added a commit
that referenced
this pull request
Jul 30, 2020
…pply with Arrow vectorization
### What changes were proposed in this pull request?
This PR proposes to:
1. Fix the error message when the output schema is misbatched with R DataFrame from the given function. For example,
```R
df <- createDataFrame(list(list(a=1L, b="2")))
count(gapply(df, "a", function(key, group) { group }, structType("a int, b int")))
```
**Before:**
```
Error in handleErrors(returnStatus, conn) :
...
java.lang.UnsupportedOperationException
...
```
**After:**
```
Error in handleErrors(returnStatus, conn) :
...
java.lang.AssertionError: assertion failed: Invalid schema from gapply: expected IntegerType, IntegerType, got IntegerType, StringType
...
```
2. Update documentation about the schema matching for `gapply` and `dapply`.
### Why are the changes needed?
To show which schema is not matched, and let users know what's going on.
### Does this PR introduce _any_ user-facing change?
Yes, error message is updated as above, and documentation is updated.
### How was this patch tested?
Manually tested and unitttests were added.
Closes #29283 from HyukjinKwon/r-vectorized-error.
Authored-by: HyukjinKwon <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
|
Test build #126798 has finished for PR 29283 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to:
Fix the error message when the output schema is misbatched with R DataFrame from the given function. For example,
Before:
After:
Update documentation about the schema matching for
gapplyanddapply.Why are the changes needed?
To show which schema is not matched, and let users know what's going on.
Does this PR introduce any user-facing change?
Yes, error message is updated as above, and documentation is updated.
How was this patch tested?
Manually tested and unitttests were added.